flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #5140: [FLINK-7797] [table] Add support for windowed oute...
Date Thu, 04 Jan 2018 18:16:09 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5140#discussion_r159698104
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamJoin.scala
---
    @@ -437,15 +427,14 @@ abstract class TimeBoundedStreamJoin(
         * Remove the expired rows. Register a new timer if the cache still holds valid rows
         * after the cleaning up.
         *
    -    * @param collector      the collector to emit results
         * @param expirationTime the expiration time for this cache
         * @param rowCache       the row cache
         * @param timerState     timer state for the opposite stream
         * @param ctx            the context to register the cleanup timer
         * @param removeLeft     whether to remove the left rows
         */
       private def removeExpiredRows(
    -      collector: Collector[Row],
    --- End diff --
    
    Why did you change the type? 
    `EmitAwareCollector` is a `Collector[Row]`.


---

Mime
View raw message