flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GJL <...@git.apache.org>
Subject [GitHub] flink pull request #5225: [FLINK-8339] [flip6] Let CustomCommandLine return ...
Date Thu, 04 Jan 2018 17:26:00 GMT
Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5225#discussion_r159703483
  
    --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
    @@ -561,7 +640,7 @@ protected int cancel(String[] args) throws Exception {
     	 *
     	 * @param args Command line arguments for the cancel action.
     	 */
    -	protected int savepoint(String[] args) throws CliArgsException {
    +	protected void savepoint(String[] args) throws Exception {
    --- End diff --
    
    Why was this changed? It's the only command which doesn't return a status code. The diff
would have been smaller without it.


---

Mime
View raw message