flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GJL <...@git.apache.org>
Subject [GitHub] flink pull request #5225: [FLINK-8339] [flip6] Let CustomCommandLine return ...
Date Thu, 04 Jan 2018 17:25:39 GMT
Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5225#discussion_r159707313
  
    --- Diff: flink-clients/src/test/java/org/apache/flink/client/cli/util/DummyClusterDescriptor.java
---
    @@ -0,0 +1,64 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.client.cli.util;
    +
    +import org.apache.flink.client.deployment.ClusterDescriptor;
    +import org.apache.flink.client.deployment.ClusterSpecification;
    +import org.apache.flink.client.program.ClusterClient;
    +import org.apache.flink.runtime.jobgraph.JobGraph;
    +import org.apache.flink.util.Preconditions;
    +
    +/**
    + * Dummy {@link ClusterDescriptor} implementation for testing purposes.
    + *
    + * @param <C> type of the returned {@link ClusterClient}
    + */
    +public class DummyClusterDescriptor<C extends ClusterClient> implements ClusterDescriptor<C>
{
    +
    +	private final C clusterClient;
    +
    +	public DummyClusterDescriptor(C clusterClient) {
    +		this.clusterClient = Preconditions.checkNotNull(clusterClient);
    +	}
    +
    +	@Override
    +	public String getClusterDescription() {
    +		return null;
    +	}
    +
    +	@Override
    +	public C retrieve(String applicationID) throws UnsupportedOperationException {
    +		return clusterClient;
    +	}
    +
    +	@Override
    +	public C deploySessionCluster(ClusterSpecification clusterSpecification) throws UnsupportedOperationException
{
    +		return clusterClient;
    +	}
    +
    +	@Override
    +	public C deployJobCluster(ClusterSpecification clusterSpecification, JobGraph jobGraph)
{
    +		return clusterClient;
    +	}
    +
    +	@Override
    +	public void close() throws Exception {
    --- End diff --
    
    nit: `throws Exception` not needed. Doesn't really matter either at the moment.


---

Mime
View raw message