flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GJL <...@git.apache.org>
Subject [GitHub] flink pull request #5223: [FLINK-8317][flip6] Implement Triggering of Savepo...
Date Tue, 02 Jan 2018 15:26:25 GMT
Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5223#discussion_r159247245
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rpc/RpcUtils.java ---
    @@ -27,11 +27,16 @@
     import java.util.concurrent.TimeoutException;
     
     /**
    - * Utility functions for Flink's RPC implementation
    + * Utility functions for Flink's RPC implementation.
      */
     public class RpcUtils {
     
    -	public static final Time INF_TIMEOUT = Time.milliseconds(Long.MAX_VALUE);
    +	/**
    +	 * <b>HACK:</b> Set to 21474835 seconds, Akka's maximum delay (Akka 2.4.20).
The value cannot be
    +	 * higher or an {@link IllegalArgumentException} will be thrown during an RPC. Check
the private
    +	 * method {@code checkMaxDelay()} in {@link akka.actor.LightArrayRevolverScheduler}.
    +	 */
    +	public static final Time INF_TIMEOUT = Time.milliseconds(TimeUnit.SECONDS.toMillis(21474835));
    --- End diff --
    
    `Time.seconds(21474835)`


---

Mime
View raw message