flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sunjincheng121 <...@git.apache.org>
Subject [GitHub] flink pull request #5202: [FLINK-8302][table]Add SHIFT_LEFT and SHIFT_RIGHT ...
Date Mon, 01 Jan 2018 01:55:48 GMT
Github user sunjincheng121 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5202#discussion_r159148500
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/sql/ScalarSqlFunctions.scala
---
    @@ -58,4 +58,22 @@ object ScalarSqlFunctions {
           OperandTypes.family(SqlTypeFamily.NUMERIC, SqlTypeFamily.NUMERIC)),
         SqlFunctionCategory.NUMERIC)
     
    +  val SHIFT_LEFT = new SqlFunction(
    +    "SHIFT_LEFT",
    +    SqlKind.OTHER_FUNCTION,
    +    ReturnTypes.ARG0,
    +    null,
    +    OperandTypes.family(SqlTypeFamily.NUMERIC, SqlTypeFamily.NUMERIC),
    +    SqlFunctionCategory.NUMERIC
    +  )
    +
    +  val SHIFT_RIGHT = new SqlFunction(
    +    "SHIFT_RIGHT",
    +    SqlKind.OTHER_FUNCTION,
    +    ReturnTypes.ARG0,
    +    null,
    +    OperandTypes.family(SqlTypeFamily.NUMERIC, SqlTypeFamily.NUMERIC),
    +    SqlFunctionCategory.NUMERIC
    --- End diff --
    
    Second operand should be  SqlTypeFamily.INTEGER.
     `OperandTypes.family(SqlTypeFamily.NUMERIC, SqlTypeFamily.NUMERIC) -> OperandTypes.family(SqlTypeFamily.NUMERIC,
SqlTypeFamily.INTEGER) `


---

Mime
View raw message