Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id BF8AC200D68 for ; Thu, 28 Dec 2017 11:35:10 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id BDFCA160C1F; Thu, 28 Dec 2017 10:35:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0FF78160C16 for ; Thu, 28 Dec 2017 11:35:09 +0100 (CET) Received: (qmail 66201 invoked by uid 500); 28 Dec 2017 10:35:09 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 66192 invoked by uid 99); 28 Dec 2017 10:35:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Dec 2017 10:35:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id D4BFA1A0A1E for ; Thu, 28 Dec 2017 10:35:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.021 X-Spam-Level: X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id ShiA1nEs6x2D for ; Thu, 28 Dec 2017 10:35:08 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 337F15FACF for ; Thu, 28 Dec 2017 10:35:07 +0000 (UTC) Received: (qmail 66145 invoked by uid 99); 28 Dec 2017 10:35:06 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Dec 2017 10:35:06 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 60C42DFDE6; Thu, 28 Dec 2017 10:35:06 +0000 (UTC) From: tony810430 To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org Message-ID: Subject: [GitHub] flink pull request #5211: [FLINK-8326] [chks] CheckpointCoordinatorTest#test... Content-Type: text/plain Date: Thu, 28 Dec 2017 10:35:06 +0000 (UTC) archived-at: Thu, 28 Dec 2017 10:35:10 -0000 GitHub user tony810430 opened a pull request: https://github.com/apache/flink/pull/5211 [FLINK-8326] [chks] CheckpointCoordinatorTest#testRestoreLatestCheckpointedStateScaleOut() didn't use the correct parameter to trigger test function ## What is the purpose of the change Correct the wrong parameter in unit test. ## Brief change log - change the parameter from `false` to `true` in `CheckpointCoordinatorTest#testRestoreLatestCheckpointedStateWithChangingParallelism(boolean scaleOut)` which was called in `CheckpointCoordinatorTest#testRestoreLatestCheckpointedStateScaleOut()` ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? not documented You can merge this pull request into a Git repository by running: $ git pull https://github.com/tony810430/flink FLINK-8326 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/5211.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5211 ---- commit 26dfa675fecdee58ddbc13412db1d48aa193dda3 Author: Tony Wei Date: 2017-12-28T10:12:58Z [FLINK-8326] CheckpointCoordinatorTest#testRestoreLatestCheckpointedStateScaleOut() didn't use the correct parameter to trigger test function ---- ---