Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Tue, 5 Dec 2017 14:50:01 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.13110860.1508466997000.389035.1512485401402@Atlassian.JIRA>
In-Reply-To: <JIRA.13110860.1508466997000@Atlassian.JIRA>
References: <JIRA.13110860.1508466997000@Atlassian.JIRA> <JIRA.13110860.1508466997462@jira-lw-us.apache.org>
Subject: [jira] [Commented] (FLINK-7878) Extend the resource type user can
 define in ResourceSpec
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 05 Dec 2017 14:50:10 -0000


    [ https://issues.apache.org/jira/browse/FLINK-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278656#comment-16278656 ] 

ASF GitHub Bot commented on FLINK-7878:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4911#discussion_r154965306
  
    --- Diff: flink-core/src/main/java/org/apache/flink/api/common/operators/ResourceSpec.java ---
    @@ -183,17 +240,124 @@ public int hashCode() {
     		result = 31 * result + directMemoryInMB;
     		result = 31 * result + nativeMemoryInMB;
     		result = 31 * result + stateSizeInMB;
    +		result = 31 * result + extendedResources.hashCode();
     		return result;
     	}
     
     	@Override
     	public String toString() {
    +		String extend = "";
    +		for (Resource resource : extendedResources.values()) {
    +			extend += ", " + resource.name + "=" + resource.value;
    +		}
     		return "ResourceSpec{" +
     				"cpuCores=" + cpuCores +
     				", heapMemoryInMB=" + heapMemoryInMB +
     				", directMemoryInMB=" + directMemoryInMB +
     				", nativeMemoryInMB=" + nativeMemoryInMB +
    -				", stateSizeInMB=" + stateSizeInMB +
    +				", stateSizeInMB=" + stateSizeInMB + extend +
     				'}';
     	}
    +
    +	public static abstract class Resource implements Serializable {
    +		final private String name;
    +
    +		final private Double value;
    --- End diff --
    
    Wrong order of keywords: `private final`


> Extend the resource type user can define in ResourceSpec
> --------------------------------------------------------
>
>                 Key: FLINK-7878
>                 URL: https://issues.apache.org/jira/browse/FLINK-7878
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataSet API, DataStream API
>            Reporter: shuai.xu
>            Assignee: shuai.xu
>              Labels: flip-6
>
> Now, flink only support user define how much CPU and MEM used in an operator, but now the resource in a cluster is various. For example, an application for image processing may need GPU, some others may need FPGA. 
> Only CPU and MEM is not enough, and the resource type is becoming more and more, so we need to make the ResourSpec extendible.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)