Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Mon, 11 Dec 2017 08:40:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.13108587.1507725310000.428288.1512981600103@Atlassian.JIRA>
In-Reply-To: <JIRA.13108587.1507725310000@Atlassian.JIRA>
References: <JIRA.13108587.1507725310000@Atlassian.JIRA> <JIRA.13108587.1507725310785@jira-lw-us.apache.org>
Subject: [jira] [Commented] (FLINK-7812) Log system resources as metrics
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 11 Dec 2017 08:40:12 -0000


    [ https://issues.apache.org/jira/browse/FLINK-7812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285647#comment-16285647 ] 

ASF GitHub Bot commented on FLINK-7812:
---------------------------------------

Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4801#discussion_r156008613
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/utils/SystemResourcesCounter.java ---
    @@ -0,0 +1,236 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.taskexecutor.utils;
    +
    +import org.apache.flink.api.common.time.Time;
    +
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +import oshi.SystemInfo;
    +import oshi.hardware.CentralProcessor;
    +import oshi.hardware.CentralProcessor.TickType;
    +import oshi.hardware.HardwareAbstractionLayer;
    +import oshi.hardware.NetworkIF;
    +
    +import javax.annotation.concurrent.ThreadSafe;
    +
    +import java.util.concurrent.atomic.AtomicLongArray;
    +import java.util.concurrent.atomic.AtomicReferenceArray;
    +
    +import static org.apache.flink.util.Preconditions.checkState;
    +
    +/**
    + * Daemon thread logging system resources.
    + *
    + * To accurately and consistently report CPU and network usage we have to periodically probe
    + * CPU ticks and network sent/received bytes and then convert those values to CPU usage and
    + * send/receive byte rates.
    + */
    +@ThreadSafe
    --- End diff --
    
    Hmmm :) This annotation is about public getters, but maybe indeed it doesn't make a lot of sense. On the other hand, is it harmful?


> Log system resources as metrics
> -------------------------------
>
>                 Key: FLINK-7812
>                 URL: https://issues.apache.org/jira/browse/FLINK-7812
>             Project: Flink
>          Issue Type: New Feature
>          Components: Metrics
>            Reporter: Piotr Nowojski
>            Assignee: Piotr Nowojski
>


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)