Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Mon, 18 Dec 2017 17:34:01 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.13095384.1502985115000.484220.1513618441423@Atlassian.JIRA>
In-Reply-To: <JIRA.13095384.1502985115000@Atlassian.JIRA>
References: <JIRA.13095384.1502985115000@Atlassian.JIRA> <JIRA.13095384.1502985115663@jira-lw-us.apache.org>
Subject: [jira] [Commented] (FLINK-7468) Implement sender backlog logic for
 credit-based
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 18 Dec 2017 17:34:08 -0000


    [ https://issues.apache.org/jira/browse/FLINK-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16295305#comment-16295305 ] 

ASF GitHub Bot commented on FLINK-7468:
---------------------------------------

Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4559#discussion_r157541024
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SubpartitionTestBase.java ---
    @@ -62,7 +70,14 @@ public void testAddAfterRelease() throws Exception {
     		try {
     			subpartition.release();
     
    +			assertEquals(0, subpartition.getTotalNumberOfBuffers());
    +			assertEquals(0, subpartition.getBuffersInBacklog());
    +			assertEquals(0, subpartition.getTotalNumberOfBytes());
    +
     			assertFalse(subpartition.add(mock(Buffer.class)));
    +			assertEquals(0, subpartition.getTotalNumberOfBuffers());
    +			assertEquals(0, subpartition.getBuffersInBacklog());
    --- End diff --
    
    same here - please test with a real `Buffer` instance


> Implement sender backlog logic for credit-based
> -----------------------------------------------
>
>                 Key: FLINK-7468
>                 URL: https://issues.apache.org/jira/browse/FLINK-7468
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Network
>            Reporter: zhijiang
>            Assignee: zhijiang
>             Fix For: 1.5.0
>
>
> This is a part of work for credit-based network flow control.
> Receivers should know how many buffers are available on the sender side (the backlog). The receivers use this information to decide how to distribute floating buffers.
> The {{ResultSubpartition}} maintains the backlog which only indicates the number of buffers in this subpartition, not including the number of events. The backlog is increased for adding buffer to this subpartition, and decreased for polling buffer from it.
> The backlog is attached in {{BufferResponse}} by sender as an absolute value after the buffer being transferred.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)