Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Mon, 4 Dec 2017 17:06:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.13093832.1502379224000.379933.1512407160654@Atlassian.JIRA>
In-Reply-To: <JIRA.13093832.1502379224000@Atlassian.JIRA>
References: <JIRA.13093832.1502379224000@Atlassian.JIRA> <JIRA.13093832.1502379224612@jira-lw-us.apache.org>
Subject: [jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing
 pipeline for credit-based
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Mon, 04 Dec 2017 17:06:06 -0000


    [ https://issues.apache.org/jira/browse/FLINK-7416?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1627=
7095#comment-16277095 ]=20

ASF GitHub Bot commented on FLINK-7416:
---------------------------------------

Github user zhijiangW commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4533#discussion_r154710910
 =20
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/netwo=
rk/partition/consumer/RemoteInputChannel.java ---
    @@ -378,6 +381,11 @@ public void notifyBufferDestroyed() {
     =09=09// Nothing to do actually.
     =09}
    =20
    +=09@VisibleForTesting
    +=09public void increaseCredit(int credit) {
    --- End diff --
   =20
    We increase credit here only to confirm the `checkState` of credit corr=
ectly during sending `AddCredit` message, not to trigger `notifyCreditAvail=
able` by increasing credit.


> Implement Netty receiver outgoing pipeline for credit-based
> -----------------------------------------------------------
>
>                 Key: FLINK-7416
>                 URL: https://issues.apache.org/jira/browse/FLINK-7416
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Network
>            Reporter: zhijiang
>            Assignee: zhijiang
>             Fix For: 1.5.0
>
>
> This is a part of work for credit-based network flow control.
> The related works are :
> *  We define a new message called {{AddCredit}} to notify the incremental=
 credit during data shuffle.=20
> * Whenever an {{InputChannel}}=E2=80=99s unannounced credit goes up from =
zero, the channel is enqueued in the pipeline.
> * Whenever the channel becomes writable, it takes the next {{InputChannel=
}} and sends its unannounced credit. The credit is reset to zero after each=
 sent.
> * That way, messages are sent as often as the network has capacity and co=
ntain as much credit as available for the channel at that point in time. Ot=
herwise, it would only add latency to the announcements and not increase th=
roughput.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)