Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: fhueske <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-5140-flink@git.apache.org>
In-Reply-To: <git-pr-5140-flink@git.apache.org>
Subject: [GitHub] flink pull request #5140: [FLINK-7797] [table] Add support for windowed oute...
Content-Type: text/plain
Message-Id: <20171229002845.A790DE01EC@git1-us-west.apache.org>
Date: Fri, 29 Dec 2017 00:28:45 +0000 (UTC)
archived-at: Fri, 29 Dec 2017 00:28:51 -0000

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5140#discussion_r159009795
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamJoin.scala ---
    @@ -62,15 +65,23 @@ abstract class TimeBoundedStreamInnerJoin(
       with Compiler[FlatJoinFunction[Row, Row, Row]]
       with Logging {
     
    -  private var cRowWrapper: CRowWrappingCollector = _
    +  private val leftArity = leftType.getArity
    +  private val rightArity = rightType.getArity
    +  private val resultArity = leftArity + rightArity
    +
    +  // two reusable padding results
    +  private val leftNullPaddingResult = new Row(resultArity)
    --- End diff --
    
    I think we can move the code to generate padded results into a util class that can be reused by other joins.


---