Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: NicoK <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-4559-flink@git.apache.org>
In-Reply-To: <git-pr-4559-flink@git.apache.org>
Subject: [GitHub] flink pull request #4559: [FLINK-7468][network] Implement sender backlog log...
Content-Type: text/plain
Message-Id: <20171218173325.0FABCDFAB0@git1-us-west.apache.org>
Date: Mon, 18 Dec 2017 17:33:25 +0000 (UTC)
archived-at: Mon, 18 Dec 2017 17:33:28 -0000

Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4559#discussion_r157538061
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartitionTest.java ---
    @@ -103,16 +104,35 @@ public void testBasicPipelinedProduceConsumeLogic() throws Exception {
     		// Add data to the queue...
     		subpartition.add(createBuffer());
     
    +		assertEquals(1, subpartition.getTotalNumberOfBuffers());
    +		assertEquals(1, subpartition.getBuffersInBacklog());
    +		assertEquals(BUFFER_SIZE, subpartition.getTotalNumberOfBytes());
    +
     		// ...should have resulted in a notification
     		verify(listener, times(1)).notifyBuffersAvailable(eq(1L));
     
     		// ...and one available result
     		assertNotNull(view.getNextBuffer());
     		assertNull(view.getNextBuffer());
    +		assertEquals(0, subpartition.getBuffersInBacklog());
     
     		// Add data to the queue...
     		subpartition.add(createBuffer());
    +
    +		assertEquals(2, subpartition.getTotalNumberOfBuffers());
    +		assertEquals(1, subpartition.getBuffersInBacklog());
    +		assertEquals(2 * BUFFER_SIZE, subpartition.getTotalNumberOfBytes());
     		verify(listener, times(2)).notifyBuffersAvailable(eq(1L));
    +
    +		// Add event to the queue...
    +		Buffer event = createBuffer();
    +		event.tagAsEvent();
    +		subpartition.add(event);
    +
    +		assertEquals(3, subpartition.getTotalNumberOfBuffers());
    +		assertEquals(1, subpartition.getBuffersInBacklog());
    --- End diff --
    
    good catch - the event-adding path was not tested yet


---