Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 94A52200D5B for ; Wed, 13 Dec 2017 17:37:55 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 934B0160C25; Wed, 13 Dec 2017 16:37:55 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E32B4160C0F for ; Wed, 13 Dec 2017 17:37:54 +0100 (CET) Received: (qmail 1547 invoked by uid 500); 13 Dec 2017 16:37:54 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 1538 invoked by uid 99); 13 Dec 2017 16:37:54 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Dec 2017 16:37:54 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 9E2DFC6CF0 for ; Wed, 13 Dec 2017 16:37:53 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.03 X-Spam-Level: X-Spam-Status: No, score=-4.03 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id iSwJFfS61kjU for ; Wed, 13 Dec 2017 16:37:53 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 88AB55F340 for ; Wed, 13 Dec 2017 16:37:52 +0000 (UTC) Received: (qmail 1504 invoked by uid 99); 13 Dec 2017 16:37:52 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Dec 2017 16:37:52 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id E7CFFDFDE6; Wed, 13 Dec 2017 16:37:51 +0000 (UTC) From: tillrohrmann To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink issue #4911: [FLINK-7878] [api] make resource type extendible in Resou... Content-Type: text/plain Message-Id: <20171213163751.E7CFFDFDE6@git1-us-west.apache.org> Date: Wed, 13 Dec 2017 16:37:51 +0000 (UTC) archived-at: Wed, 13 Dec 2017 16:37:55 -0000 Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4911 Changes look good @shuai-xu. I have a single last question which is whether we want to expose the `GpuResource` to the user or not. Wouldn't it be enough to set the gpus via `Builder#setGpuResource(double)`? Of course, then we weren't able to set the `ResourceAggregateType` but I'm wondering whether GPUs shouldn't be something else than the sum. We actually have the same problem with the cpus. They are hardcoded to be the max of both values. ---