Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CEF09200D54 for ; Fri, 8 Dec 2017 11:12:03 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id CD4D9160C0D; Fri, 8 Dec 2017 10:12:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1EAD3160BF2 for ; Fri, 8 Dec 2017 11:12:02 +0100 (CET) Received: (qmail 72327 invoked by uid 500); 8 Dec 2017 10:12:02 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 72318 invoked by uid 99); 8 Dec 2017 10:12:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Dec 2017 10:12:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id DD9D11A024D for ; Fri, 8 Dec 2017 10:12:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.021 X-Spam-Level: X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id jdiZns5QHkVy for ; Fri, 8 Dec 2017 10:12:01 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id CA7E15F39E for ; Fri, 8 Dec 2017 10:12:00 +0000 (UTC) Received: (qmail 72295 invoked by uid 99); 8 Dec 2017 10:12:00 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Dec 2017 10:12:00 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 34F01ED49C; Fri, 8 Dec 2017 10:12:00 +0000 (UTC) From: aljoscha To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request #5125: [WIP][FLINK-4812][metrics] Expose currentLowWaterm... Content-Type: text/plain Message-Id: <20171208101200.34F01ED49C@git1-us-west.apache.org> Date: Fri, 8 Dec 2017 10:12:00 +0000 (UTC) archived-at: Fri, 08 Dec 2017 10:12:04 -0000 Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/5125#discussion_r155742906 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/TwoInputStreamTask.java --- @@ -80,7 +91,10 @@ public void init() throws Exception { this.headOperator); // make sure that stream tasks report their I/O statistics - inputProcessor.setMetricGroup(getEnvironment().getMetricGroup().getIOMetricGroup()); + inputProcessor.setupMetrics(getEnvironment().getMetricGroup().getIOMetricGroup(), input1WatermarkGauge, input2WatermarkGauge); + + headOperator.getMetricGroup().gauge(MetricNames.IO_CURRENT_INPUT_1_WATERMARK, input1WatermarkGauge); --- End diff -- Sure, I think that makes sense. ---