Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 49136200D53 for ; Tue, 5 Dec 2017 11:46:07 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 478F2160C1B; Tue, 5 Dec 2017 10:46:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8B4FC160C0A for ; Tue, 5 Dec 2017 11:46:06 +0100 (CET) Received: (qmail 14620 invoked by uid 500); 5 Dec 2017 10:46:05 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 14611 invoked by uid 99); 5 Dec 2017 10:46:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Dec 2017 10:46:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 0DE8EC493F for ; Tue, 5 Dec 2017 10:46:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.03 X-Spam-Level: X-Spam-Status: No, score=-4.03 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id B5vVBi-lUnIn for ; Tue, 5 Dec 2017 10:46:04 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 22FB75F2C4 for ; Tue, 5 Dec 2017 10:46:04 +0000 (UTC) Received: (qmail 14591 invoked by uid 99); 5 Dec 2017 10:46:03 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Dec 2017 10:46:03 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id B54C9E00BD; Tue, 5 Dec 2017 10:46:02 +0000 (UTC) From: tony810430 To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request #5115: [FLINK-7692] [metrics] Support user-defined variab... Content-Type: text/plain Message-Id: <20171205104602.B54C9E00BD@git1-us-west.apache.org> Date: Tue, 5 Dec 2017 10:46:02 +0000 (UTC) archived-at: Tue, 05 Dec 2017 10:46:07 -0000 Github user tony810430 commented on a diff in the pull request: https://github.com/apache/flink/pull/5115#discussion_r154907808 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java --- @@ -409,6 +404,22 @@ public MetricGroup addGroup(String name) { return addGroup(name, false); } + @Override + public MetricGroup addGroup(String key, String value) { --- End diff -- In the below case, the `subGroup2` will get a `GenericValueMetricGroup` back. ``` val subGroup = group.addGroup("key", "value") val subGroup2 = group.addGroup("key").addGroup("value") ``` I prefer not to change the behavior of original API, so I think it is better to return a `GenericMetricGroup`. ---