Return-Path: <issues-return-143400-archive-asf-public=cust-asf.ponee.io@flink.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id DEE5E200D53
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Tue,  5 Dec 2017 09:51:38 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id DD790160C1B; Tue,  5 Dec 2017 08:51:38 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 55B72160C0A
	for <archive-asf-public@cust-asf.ponee.io>; Tue,  5 Dec 2017 09:51:38 +0100 (CET)
Received: (qmail 46033 invoked by uid 500); 5 Dec 2017 08:51:37 -0000
Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@flink.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@flink.apache.org>
List-Post: <mailto:issues@flink.apache.org>
List-Id: <issues.flink.apache.org>
Reply-To: dev@flink.apache.org
Delivered-To: mailing list issues@flink.apache.org
Received: (qmail 46024 invoked by uid 99); 5 Dec 2017 08:51:37 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Dec 2017 08:51:37 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id C0A671A0D23
	for <issues@flink.apache.org>; Tue,  5 Dec 2017 08:51:36 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: -3.521
X-Spam-Level: 
X-Spam-Status: No, score=-3.521 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, KAM_LINKBAIT=0.5,
	RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,
	RP_MATCHES_RCVD=-0.001] autolearn=disabled
Received: from mx1-lw-eu.apache.org ([10.40.0.8])
	by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024)
	with ESMTP id wdXGuADBDjy6 for <issues@flink.apache.org>;
	Tue,  5 Dec 2017 08:51:36 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 1F72D5F2A8
	for <issues@flink.incubator.apache.org>; Tue,  5 Dec 2017 08:51:34 +0000 (UTC)
Received: (qmail 45994 invoked by uid 99); 5 Dec 2017 08:51:33 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Dec 2017 08:51:33 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id D11D9E2F03; Tue,  5 Dec 2017 08:51:33 +0000 (UTC)
From: aljoscha <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-5098-flink@git.apache.org>
In-Reply-To: <git-pr-5098-flink@git.apache.org>
Subject: [GitHub] flink pull request #5098: [FLINK-8007][metrics] Move TestMeter/-Histogram in...
Content-Type: text/plain
Message-Id: <20171205085133.D11D9E2F03@git1-us-west.apache.org>
Date: Tue,  5 Dec 2017 08:51:33 +0000 (UTC)
archived-at: Tue, 05 Dec 2017 08:51:39 -0000

Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5098#discussion_r154879555
  
    --- Diff: flink-metrics/flink-metrics-datadog/pom.xml ---
    @@ -88,6 +65,7 @@ under the License.
     							<goal>shade</goal>
     						</goals>
     						<configuration>
    +							<promoteTransitiveDependencies>true</promoteTransitiveDependencies>
    --- End diff --
    
    Why is this needed now?


---