Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3C45D200D62 for ; Fri, 1 Dec 2017 14:38:36 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 3B172160BFB; Fri, 1 Dec 2017 13:38:36 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 821C5160C06 for ; Fri, 1 Dec 2017 14:38:35 +0100 (CET) Received: (qmail 7490 invoked by uid 500); 1 Dec 2017 13:38:34 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 7464 invoked by uid 99); 1 Dec 2017 13:38:34 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Dec 2017 13:38:34 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 03C95180859 for ; Fri, 1 Dec 2017 13:38:34 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -3.221 X-Spam-Level: X-Spam-Status: No, score=-3.221 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id rOYQbsfY0LQ0 for ; Fri, 1 Dec 2017 13:38:33 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id CD5205F24A for ; Fri, 1 Dec 2017 13:38:32 +0000 (UTC) Received: (qmail 7316 invoked by uid 99); 1 Dec 2017 13:38:32 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Dec 2017 13:38:32 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 4EE6DDFA0C; Fri, 1 Dec 2017 13:38:32 +0000 (UTC) From: NicoK To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request #4559: [FLINK-7468][network] Implement sender backlog log... Content-Type: text/plain Message-Id: <20171201133832.4EE6DDFA0C@git1-us-west.apache.org> Date: Fri, 1 Dec 2017 13:38:32 +0000 (UTC) archived-at: Fri, 01 Dec 2017 13:38:36 -0000 Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4559#discussion_r154344942 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/CancelPartitionRequestTest.java --- @@ -174,19 +175,21 @@ public ResultSubpartitionView answer(InvocationOnMock invocationOnMock) throws T // --------------------------------------------------------------------------------------------- - static class InfiniteSubpartitionView implements ResultSubpartitionView { + static class InfiniteSubpartitionView extends ResultSubpartitionView { private final BufferProvider bufferProvider; private final CountDownLatch sync; public InfiniteSubpartitionView(BufferProvider bufferProvider, CountDownLatch sync) { + super(mock(ResultSubpartition.class)); + this.bufferProvider = checkNotNull(bufferProvider); this.sync = checkNotNull(sync); } @Override - public Buffer getNextBuffer() throws IOException, InterruptedException { + protected Buffer getNextBufferInternal() throws IOException, InterruptedException { --- End diff -- `@Nullable` ---