flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8328) Pull Yarn ApplicationStatus polling out of YarnClusterClient
Date Fri, 29 Dec 2017 17:18:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16306391#comment-16306391
] 

ASF GitHub Bot commented on FLINK-8328:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/5215

    [FLINK-8328] [flip6] Move Yarn ApplicationStatus polling out of YarnClusterClient

    ## What is the purpose of the change
    
    Introduce YarnApplicationStatusMonitor which does the Yarn ApplicationStatus polling in
    the FlinkYarnSessionCli. This decouples the YarnClusterClient from the actual communication
    with Yarn and, thus, gives a better separation of concerns.
    
    ## Brief change log
    
    - Replace the `PollingThread` with the `YarnApplicationStatusMonitor`
    - Decouple `YarnClusterClient` from Yarn `ApplicationStatus` polling
    
    ## Verifying this change
    
    - Changes covered by existing tests
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (yes)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink removeSpecialClusterClients

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5215.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5215
    
----
commit 69ef9787f1278f40bfeaa685379648297e1cb6f0
Author: Till Rohrmann <trohrmann@...>
Date:   2017-12-07T12:57:24Z

    [FLINK-8328] [flip6] Move Yarn ApplicationStatus polling out of YarnClusterClient
    
    Introduce YarnApplicationStatusMonitor which does the Yarn ApplicationStatus polling in
    the FlinkYarnSessionCli. This decouples the YarnClusterClient from the actual communication
    with Yarn and, thus, gives a better separation of concerns.

----


> Pull Yarn ApplicationStatus polling out of YarnClusterClient
> ------------------------------------------------------------
>
>                 Key: FLINK-8328
>                 URL: https://issues.apache.org/jira/browse/FLINK-8328
>             Project: Flink
>          Issue Type: Improvement
>          Components: Client
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> In order to make the {{FlinkYarnSessionCli}} work with Flip-6, we have to pull the Yarn
{{ApplicationStatus}} polling out of the {{YarnClusterClient}}. I propose to introduce a dedicated
{{YarnApplicationStatusMonitor}}. This has also the benefit of separating concerns better.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message