flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8295) Netty shading does not work properly
Date Tue, 19 Dec 2017 17:24:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16297113#comment-16297113
] 

ASF GitHub Bot commented on FLINK-8295:
---------------------------------------

GitHub user NicoK opened a pull request:

    https://github.com/apache/flink/pull/5183

    [FLINK-8295][cassandra][build] properly shade netty for the datastax driver

    ## What is the purpose of the change
    
    `com.datastax.driver.core.NettyUtil` expects netty to be present either at its original
package (`io.netty`) or relocated to `com.datastax.shaded.netty`. By relocating it to this
package we make sure the driver follows its designated path and is able to connect at all.
    
    ## Brief change log
    
    - relocate netty to  `com.datastax.shaded.netty` instead of our own namespace
    
    ## Verifying this change
    
    This change added tests and can be verified as follows:
    
    - verified the build jar contains netty (only) in `com.datastax.shaded.netty` and not
under `org.apache.flink.cassandra.shaded.io.netty`
    - run a job that uses cassandra (should not have worked without adding netty before and
should work now - haven't tested it yet - @twalthr can you jump in here?)
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): **no**
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
      - The serializers: **no**
      - The runtime per-record code paths (performance sensitive): **no**
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: **no**
      - The S3 file system connector: **no**
    
    ## Documentation
    
      - Does this pull request introduce a new feature? **no**
      - If yes, how is the feature documented? **not applicable**

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NicoK/flink flink-8295

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5183.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5183
    
----
commit 80c00a28dbf01ab4f31220c2005d7eeee8a76316
Author: Nico Kruber <nico@data-artisans.com>
Date:   2017-12-19T17:14:19Z

    [FLINK-8295][cassandra][build] properly shade netty for the datastax driver
    
    com.datastax.driver.core.NettyUtil expects netty to be present either at its
    original package or relocated to com.datastax.shaded.netty. By relocating it
    to this package we make sure the driver follows its designated path.

----


> Netty shading does not work properly
> ------------------------------------
>
>                 Key: FLINK-8295
>                 URL: https://issues.apache.org/jira/browse/FLINK-8295
>             Project: Flink
>          Issue Type: Bug
>          Components: Cassandra Connector, Core
>    Affects Versions: 1.4.0
>            Reporter: Timo Walther
>            Assignee: Nico Kruber
>
> Multiple users complained that the Cassandra connector is not usable in Flink 1.4.0 due
to wrong/insufficient shading of Netty.
> See:
> http://mail-archives.apache.org/mod_mbox/flink-user/201712.mbox/%3Cb1f584b918c8aaf98b744c168407b0f5%40dbruhn.de%3E
> http://mail-archives.apache.org/mod_mbox/flink-user/201712.mbox/%3CCACk7FTgMPR03bPBoKzmeVKCqS%2BumTR1u1X%2BKdPtHRgbnUZiO3A%40mail.gmail.com%3E



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message