flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8241) Remove ResultPartitionWriter related PrepareForTest annotations
Date Mon, 11 Dec 2017 17:27:07 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16286292#comment-16286292
] 

ASF GitHub Bot commented on FLINK-8241:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/5147

    [FLINK-8241][tests] Remove ResultPartitionWriter-related "@PrepareForTest" annotations

    ## What is the purpose of the change
    
    This is a cleanup PR that removes usages of powermocks `@PrepareForTest` annotation for
the {{ResultPartitionWriter}} class. These are no longer necessary with the latest refactorings.
    
    ## Brief change log
    
    * remove all instances where the {{ResultPartitionWriter}} was used for {{@PrepareForTest}}
annotations
    * adjusted (now) outdated javadocs
    
    ## Verifying this change
    
    Run on travis.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 8241

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5147.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5147
    
----
commit ec8f725980539457f92ca0944559392b727084d9
Author: zentol <chesnay@apache.org>
Date:   2017-12-11T14:31:57Z

    [FLINK-8241][tests] Remove ResultPartitionWriter-related "@PrepareForTest" annotations

----


> Remove ResultPartitionWriter related PrepareForTest annotations
> ---------------------------------------------------------------
>
>                 Key: FLINK-8241
>                 URL: https://issues.apache.org/jira/browse/FLINK-8241
>             Project: Flink
>          Issue Type: Improvement
>          Components: Network, Tests
>    Affects Versions: 1.5.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: 1.5.0
>
>
> With the latest refactorings around the {{ResultPartitionWriter}} we no longer have to
use {{@PrepareForTest}} annotations for it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message