flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8193) Rework quickstart exclusions
Date Tue, 05 Dec 2017 08:34:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278194#comment-16278194
] 

ASF GitHub Bot commented on FLINK-8193:
---------------------------------------

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/5118
  
    As for failing the build, I don't like that option, even if I find a way to do it. We
_do not know_ how such a kill-switch would interact with various IDEs and tools.
    
    What we could do however is print a warning if mvn package/install is invoked without
specifying the build-jar profile.


> Rework quickstart exclusions
> ----------------------------
>
>                 Key: FLINK-8193
>                 URL: https://issues.apache.org/jira/browse/FLINK-8193
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System, Quickstarts
>    Affects Versions: 1.4.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>
> The quickstart poms currently contain 2 entirely separate dependency exclusion mechanisms:
> A) manual exclusions of dependencies (including transitive dependencies) via the {{artifactSet}}
of the {{maven-shade-plugin}}
> B) automatic inclusion by marking dependencies as {{<provided>}} with the {{build-jar}}
profile
> I propose removing A) entirely. By default, all dependencies will be included in the
jar to allow execution in the IDE (which setting all dependencies to provided would not).
To execute things on a cluster we now always refer to Option B), which is trivial to maintain
and also reliable.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message