flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8193) Rework quickstart exclusions
Date Mon, 04 Dec 2017 17:43:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16277142#comment-16277142
] 

ASF GitHub Bot commented on FLINK-8193:
---------------------------------------

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/5118
  
    I think that the change of `1.` is actually not necessary. The dependencies were good
in my opinion:
      -  `flink-core` is not directly needed, because it is a transitive dependency of `flink-java`
and `flink-streaming-java`. Omitting this unnecessary dependency makes it easier to keep the
`-Pbuild-jar` profile in sync with the normal profile.
      - We added `flink-clients` explicitly because that is actually really the dependency
needed to execute programs (is needed in the DataSet API, flink-java is not enough). It is
only redundant at the moment because `flink-streaming-java` depends on `flink-clients`, which
is not really nice and probably subject to change in the future.



> Rework quickstart exclusions
> ----------------------------
>
>                 Key: FLINK-8193
>                 URL: https://issues.apache.org/jira/browse/FLINK-8193
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System, Quickstarts
>    Affects Versions: 1.4.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>
> The quickstart poms currently contain 2 entirely separate dependency exclusion mechanisms:
> A) manual exclusions of dependencies (including transitive dependencies) via the {{artifactSet}}
of the {{maven-shade-plugin}}
> B) automatic inclusion by marking dependencies as {{<provided>}} with the {{build-jar}}
profile
> I propose removing A) entirely. By default, all dependencies will be included in the
jar to allow execution in the IDE (which setting all dependencies to provided would not).
To execute things on a cluster we now always refer to Option B), which is trivial to maintain
and also reliable.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message