flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8181) Kafka producer's FlinkFixedPartitioner returns different partitions when a target topic is rescaled
Date Mon, 04 Dec 2017 11:40:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16276653#comment-16276653
] 

ASF GitHub Bot commented on FLINK-8181:
---------------------------------------

Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/5108
  
    After some offline discussion with @aljoscha, we decided to leave the `FlinkFixedPartitioner`
as it is, and close this PR. I personally also agree with this mainly due to:
    
    > However, if we were to re-visit the semantics of the fixed partitioner, it could
be that it actually makes more sense that the fixed partitioner switches partition on scaling
out Kafka.
    Since 9ed9b68 is actually part of Flink 1.3 already, and we haven't received any complaints
so far on the changed semantics, it definitely is arguable that we don't really need to apply
this PR fix at all.


> Kafka producer's FlinkFixedPartitioner returns different partitions when a target topic
is rescaled
> ---------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-8181
>                 URL: https://issues.apache.org/jira/browse/FLINK-8181
>             Project: Flink
>          Issue Type: Bug
>          Components: Kafka Connector
>    Affects Versions: 1.4.0, 1.5.0
>            Reporter: Tzu-Li (Gordon) Tai
>            Assignee: Tzu-Li (Gordon) Tai
>            Priority: Blocker
>             Fix For: 1.4.0, 1.5.0
>
>
> On fixing FLINK-6288 and migrating the original {{FlinkFixedPartitioner}} to the new
partitioning API (commit 9ed9b68397b51bfd2b0f6e532212a82f771641bd), the {{FlinkFixedPartitioner}}
no longer returns identical target partitions once a target topic is rescaled.
> This results in a behavioral regression when the {{FlinkFixedPartitioner}} is used.
> The {{FlinkFixedPartitionerTest}} should also be strengthened to cover the target topic
rescaling case.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message