flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder
Date Tue, 12 Dec 2017 17:06:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16287895#comment-16287895
] 

ASF GitHub Bot commented on FLINK-8178:
---------------------------------------

Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5105#discussion_r156392377
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordWriterTest.java
---
    @@ -360,7 +367,7 @@ public void testBroadcastEventMixedRecords() throws Exception {
     			queues[i] = new ArrayDeque<>();
     		}
     
    -		BufferProvider bufferProvider = createBufferProvider(bufferSize);
    +		TestPooledBufferProvider bufferProvider = new TestPooledBufferProvider(Integer.MAX_VALUE,
bufferSize);
    --- End diff --
    
    why not also change the `createBufferProvider()` call in line 327 and remove both `createBufferProvider`
methods?


> Introduce not threadsafe write only BufferBuilder
> -------------------------------------------------
>
>                 Key: FLINK-8178
>                 URL: https://issues.apache.org/jira/browse/FLINK-8178
>             Project: Flink
>          Issue Type: Improvement
>          Components: Network
>            Reporter: Piotr Nowojski
>            Assignee: Piotr Nowojski
>             Fix For: 1.5.0
>
>
> While Buffer class is used in multithreaded context it requires synchronisation. Now
it is miss-leading/unclear and suggesting that RecordSerializer should take into account synchronisation
of the Buffer that's holding. With NotThreadSafe BufferBuilder there would be clear separation
between single-threaded writing/creating a BufferBuilder and multithreaded Buffer handling/retaining/recycling.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message