flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8175) remove flink-streaming-contrib and migrate its classes to flink-streaming-java/scala
Date Sat, 02 Dec 2017 08:29:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16275472#comment-16275472
] 

ASF GitHub Bot commented on FLINK-8175:
---------------------------------------

GitHub user bowenli86 opened a pull request:

    https://github.com/apache/flink/pull/5112

    [FLINK-8175] remove flink-streaming-contrib and migrate its classes to flink-streaming-java/scala

    ## What is the purpose of the change
    
    This is the first step to clean up flink-contrib. More details in (FLINK-8188)[https://issues.apache.org/jira/browse/FLINK-8188]
    
    This PR removes `flink-streaming-contrib` from `flink-contrib`, and migrates its classes
to `flink-streaming-java/scala` for the following reasons:
    
    - `flink-streaming-contrib` is so small that it only has 4 classes (3 java and 1 scala),
and they don't need a dedicated jar for Flink to distribute and maintain it and for users
to deal with the overhead of dependency management
    - the 4 classes in `flink-streaming-contrib` are logically more tied to `flink-streaming-java/scala`,
and thus can be easily migrated
    - `flink-contrib` is already too crowded and noisy. It contains lots of sub modules with
different purposes which confuse developers and users, and they lack a proper project hierarchy
    
    ## Brief change log
    
    This PR removes `flink-streaming-contrib` from `flink-contrib`, and migrates its classes
to `flink-streaming-java/scala`
    
    ## Verifying this change
    
    This change is already covered by existing tests:
    
    - `SocketStreamIteratorTest` is moved to `flink-streaming-java`
    - `CollectITCase` is moved to `flink-tests`
    
    ## Does this pull request potentially affect one of the following parts:
    
    none
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (docs / JavaDocs)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bowenli86/flink FLINK-8175

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5112.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5112
    
----
commit 4d63089ebc8912e910fc9820daa617866741ad31
Author: Bowen Li <bowenli86@gmail.com>
Date:   2017-12-02T08:18:57Z

    [FLINK-8175] remove flink-streaming-contrib and migrate its classes to flink-streaming-java/scala

commit cc87a1c1afb21070d3bf8d46f7b7b3d3639f8eda
Author: Bowen Li <bowenli86@gmail.com>
Date:   2017-12-02T08:27:20Z

    update doc

----


> remove flink-streaming-contrib and migrate its classes to flink-streaming-java/scala
> ------------------------------------------------------------------------------------
>
>                 Key: FLINK-8175
>                 URL: https://issues.apache.org/jira/browse/FLINK-8175
>             Project: Flink
>          Issue Type: Sub-task
>    Affects Versions: 1.5.0
>            Reporter: Bowen Li
>            Assignee: Bowen Li
>             Fix For: 1.5.0
>
>
> I propose removing flink-streaming-contrib from flink-contrib, and migrating its classes
to flink-streaming-java/scala for the following reasons:
> - flink-streaming-contrib is so small that it only has 4 classes (3 java and 1 scala),
and they don't need a dedicated jar for Flink to distribute and maintain it and for users
to deal with the overhead of dependency management
> - the 4 classes in flink-streaming-contrib are logically more tied to flink-streaming-java/scala,
and thus can be easily migrated
> - flink-contrib is already too crowded and noisy. It contains lots of sub modules with
different purposes which confuse developers and users, and they lack a proper project hierarchy
> To take a step even forward, I would argue that even flink-contrib should be removed
and all its submodules should be migrated to other top-level modules for the following reasons:
1) Apache Flink the whole project itself is a result of contributions from many developers,
there's no reason to highlight some contributions in a dedicated module named 'contrib' 2)
flink-contrib inherently doesn't have a good hierarchy to hold submodules



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message