flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8174) Mesos RM unable to accept offers for unreserved resources
Date Tue, 05 Dec 2017 13:51:02 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278570#comment-16278570
] 

ASF GitHub Bot commented on FLINK-8174:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5114#discussion_r154723628
  
    --- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/Utils.java ---
    @@ -101,4 +106,59 @@
     			.setRole(role)
     			.build();
     	}
    +
    +	/**
    +	 * Gets a stream of values from a collection of range resources.
    +	 */
    +	public static LongStream rangeValues(Collection<Protos.Resource> resources) {
    +		return resources.stream()
    +			.filter(Protos.Resource::hasRanges)
    +			.flatMap(r -> r.getRanges().getRangeList().stream())
    +			.flatMapToLong(Utils::rangeValues);
    +	}
    +
    +	/**
    +	 * Gets a stream of values from a range.
    +	 */
    +	public static LongStream rangeValues(Protos.Value.Range range) {
    +		return LongStream.rangeClosed(range.getBegin(), range.getEnd());
    +	}
    +
    +	/**
    +	 * Gets a string representation of a collection of resources.
    +	 */
    +	public static String print(Collection<Protos.Resource> resources) {
    --- End diff --
    
    Shall we rename this method to `toString` or something similar, because `print` does not
really print the string value.


> Mesos RM unable to accept offers for unreserved resources
> ---------------------------------------------------------
>
>                 Key: FLINK-8174
>                 URL: https://issues.apache.org/jira/browse/FLINK-8174
>             Project: Flink
>          Issue Type: Bug
>          Components: Mesos
>    Affects Versions: 1.4.0, 1.3.3
>            Reporter: Eron Wright 
>            Assignee: Eron Wright 
>            Priority: Blocker
>             Fix For: 1.4.0
>
>
> Flink has suffered a regression due to FLINK-7294.   Any attempt to accept a resource
offer that is based on unreserved resources will fail, because Flink (as of FLINK-7294) erroneously
insists that the resource come from a prior reservation.
> Looking at the original issue, the problem may have been misdiagnosed.  Ideally Flink
should work with both reserved and unreserved resources, but the latter is a more common situation
that is now broken.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message