flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8139) Check for proper equals() and hashCode() when registering a table
Date Tue, 05 Dec 2017 15:06:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278686#comment-16278686

ASF GitHub Bot commented on FLINK-8139:

Github user twalthr commented on a diff in the pull request:

    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala
    @@ -98,7 +98,9 @@ abstract class BatchTableEnvironment(
         tableSource match {
           case batchTableSource: BatchTableSource[_] =>
    -        registerTableInternal(name, new BatchTableSourceTable(batchTableSource))
    +        val table = new BatchTableSourceTable(batchTableSource)
    +        checkValidTableSourceType(tableSource)
    +        registerTableInternal(name, table)
    --- End diff --
    Couldn't we just add the check in `registerTableInternal`?

> Check for proper equals() and hashCode() when registering a table
> -----------------------------------------------------------------
>                 Key: FLINK-8139
>                 URL: https://issues.apache.org/jira/browse/FLINK-8139
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Aegeaner
> In the current Table API & SQL implementation we compare {{Row}}s at different positions.
E.g., for joining we test rows for equality or put them into state. A heap state backend requires
proper hashCode() and equals() in order to work correct. Thus, every type in the Table API
needs to have these methods implemented.
> We need to check if all fields of a row have implement methods that differ from {{Object.equals()}}
and {{Object.hashCode()}} via reflections. Both coming from TableSource and DataStream/DataSet.
> Additionally, for array types, the {{Row}} class should use {{Arrays.deepEquals()}} and
{{Arrays.deepHashCode()}} instead of the non-deep variants.

This message was sent by Atlassian JIRA

View raw message