flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8116) Stale comments referring to Checkpointed interface
Date Mon, 18 Dec 2017 21:33:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16295695#comment-16295695
] 

ASF GitHub Bot commented on FLINK-8116:
---------------------------------------

Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5121#discussion_r157606375
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/SourceFunction.java
---
    @@ -61,9 +61,9 @@
      *          isRunning = false;
      *      }
      *
    - *      public Long snapshotState(long checkpointId, long checkpointTimestamp) { return
count; }
    + *      public void snapshotState(FunctionSnapshotContext context) {  }
      *
    - *      public void restoreState(Long state) { this.count = state; }
    + *      public void initializeState(FunctionInitializationContext context) {  }
    --- End diff --
    
    These methods should handle checkpointing of the count state.
    



> Stale comments referring to Checkpointed interface
> --------------------------------------------------
>
>                 Key: FLINK-8116
>                 URL: https://issues.apache.org/jira/browse/FLINK-8116
>             Project: Flink
>          Issue Type: Bug
>          Components: DataStream API, Documentation
>            Reporter: Gabor Gevay
>            Priority: Trivial
>              Labels: starter
>             Fix For: 1.5.0
>
>
> Between Flink 1.1 and 1.2, the {{Checkpointed}} interface was superseded by the {{CheckpointedFunction}}
interface.
> However, in {{SourceFunction}} there are two comments still referring to the old {{Checkpointed}}
interface. (The code examples there also need to be modified.)
> Note that the problem also occurs in {{StreamExecutionEnvironment}}, and possibly other
places as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message