flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7956) Add support for scheduling with slot sharing
Date Thu, 07 Dec 2017 18:40:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16282300#comment-16282300
] 

ASF GitHub Bot commented on FLINK-7956:
---------------------------------------

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5091#discussion_r155605251
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/LogicalSlot.java
---
    @@ -0,0 +1,165 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.jobmaster;
    +
    +import org.apache.flink.runtime.clusterframework.types.AllocationID;
    +import org.apache.flink.runtime.instance.SlotSharingGroupId;
    +import org.apache.flink.runtime.jobmanager.scheduler.Locality;
    +import org.apache.flink.runtime.jobmanager.slots.TaskManagerGateway;
    +import org.apache.flink.runtime.taskmanager.TaskManagerLocation;
    +
    +import javax.annotation.Nullable;
    +
    +import java.util.concurrent.CompletableFuture;
    +
    +/**
    + * A logical slot represents a resource on a TaskManager into
    + * which a single task can be deployed.
    + */
    +public interface LogicalSlot {
    +
    +	 Payload TERMINATED_PAYLOAD = new Payload() {
    +
    +		private final CompletableFuture<?> COMPLETED_TERMINATION_FUTURE = CompletableFuture.completedFuture(null);
    --- End diff --
    
    nit: `COMPLETED_TERMINATION_FUTURE` should be camel cased because is not actually a constant
(not static).


> Add support for scheduling with slot sharing
> --------------------------------------------
>
>                 Key: FLINK-7956
>                 URL: https://issues.apache.org/jira/browse/FLINK-7956
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Scheduler
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>              Labels: flip-6
>
> In order to reach feature equivalence with the old code base, we should add support for
scheduling with slot sharing to the {{SlotPool}}. This will also allow us to run all the IT
cases based on the {{AbstractTestBase}} on the Flip-6 {{MiniCluster}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message