flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7878) Extend the resource type user can define in ResourceSpec
Date Tue, 05 Dec 2017 14:50:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278652#comment-16278652
] 

ASF GitHub Bot commented on FLINK-7878:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4911#discussion_r154964974
  
    --- Diff: flink-core/src/main/java/org/apache/flink/api/common/operators/ResourceSpec.java
---
    @@ -133,14 +162,31 @@ public int getStateSize() {
     		return this.stateSizeInMB;
     	}
     
    +	public Map<String, Double> getExtendedResources() {
    +		Map<String, Double> resources = new HashMap<>(extendedResources.size());
    +		for (Resource resource : extendedResources.values()) {
    +			resources.put(resource.name, resource.value);
    +		}
    +		return Collections.unmodifiableMap(resources);
    +	}
    --- End diff --
    
    Let's remove this method because it expose the internal resources.


> Extend the resource type user can define in ResourceSpec
> --------------------------------------------------------
>
>                 Key: FLINK-7878
>                 URL: https://issues.apache.org/jira/browse/FLINK-7878
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataSet API, DataStream API
>            Reporter: shuai.xu
>            Assignee: shuai.xu
>              Labels: flip-6
>
> Now, flink only support user define how much CPU and MEM used in an operator, but now
the resource in a cluster is various. For example, an application for image processing may
need GPU, some others may need FPGA. 
> Only CPU and MEM is not enough, and the resource type is becoming more and more, so we
need to make the ResourSpec extendible.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message