flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7812) Log system resources as metrics
Date Thu, 07 Dec 2017 12:13:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281766#comment-16281766
] 

ASF GitHub Bot commented on FLINK-7812:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4801#discussion_r155501129
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunnerITCase.java
---
    @@ -0,0 +1,132 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.taskexecutor;
    +
    +import org.apache.flink.configuration.Configuration;
    +import org.apache.flink.metrics.Gauge;
    +import org.apache.flink.metrics.MetricConfig;
    +import org.apache.flink.metrics.reporter.AbstractReporter;
    +import org.apache.flink.runtime.minicluster.MiniCluster;
    +import org.apache.flink.runtime.minicluster.MiniClusterConfiguration;
    +
    +import org.junit.AfterClass;
    +import org.junit.BeforeClass;
    +import org.junit.Test;
    +
    +import java.util.Collection;
    +import java.util.Map;
    +import java.util.Set;
    +import java.util.concurrent.ConcurrentHashMap;
    +
    +import static org.apache.flink.configuration.MetricOptions.REPORTERS_LIST;
    +import static org.apache.flink.configuration.TaskManagerOptions.ADDITIONAL_LOGGING;
    +import static org.junit.Assert.assertEquals;
    +import static org.junit.Assert.fail;
    +
    +/**
    + * Integration tests for proper initialization in the {@link TaskManagerRunner}.
    + */
    +public class TaskManagerRunnerITCase {
    --- End diff --
    
    This test seems very specific to this logging, but is named as a generic TaskManagerRunner
test. Give it a differnet name?
    
    Separate question: Does it have to be an IT case that fully starts the TM, or can it be
a unit test that checks config propagation?


> Log system resources as metrics
> -------------------------------
>
>                 Key: FLINK-7812
>                 URL: https://issues.apache.org/jira/browse/FLINK-7812
>             Project: Flink
>          Issue Type: New Feature
>          Components: Metrics
>            Reporter: Piotr Nowojski
>            Assignee: Piotr Nowojski
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message