flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7797) Add support for windowed outer joins for streaming tables
Date Fri, 29 Dec 2017 00:29:18 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305853#comment-16305853
] 

ASF GitHub Bot commented on FLINK-7797:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5140#discussion_r159010195
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamJoin.scala
---
    @@ -143,29 +172,14 @@ abstract class TimeBoundedStreamInnerJoin(
           ctx: CoProcessFunction[CRow, CRow, CRow]#Context,
           out: Collector[CRow]): Unit = {
     
    +    joinCollector.setCollector(out)
    --- End diff --
    
    Directly set the variable to avoid the method call (like `CRowWrappingCollector`).


> Add support for windowed outer joins for streaming tables
> ---------------------------------------------------------
>
>                 Key: FLINK-7797
>                 URL: https://issues.apache.org/jira/browse/FLINK-7797
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>    Affects Versions: 1.4.0
>            Reporter: Fabian Hueske
>            Assignee: Xingcan Cui
>
> Currently, only windowed inner joins for streaming tables are supported.
> This issue is about adding support for windowed LEFT, RIGHT, and FULL OUTER joins.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message