flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7797) Add support for windowed outer joins for streaming tables
Date Fri, 29 Dec 2017 00:29:18 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305850#comment-16305850
] 

ASF GitHub Bot commented on FLINK-7797:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5140#discussion_r159012976
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamJoin.scala
---
    @@ -382,6 +498,29 @@ abstract class TimeBoundedStreamInnerJoin(
         }
       }
     
    +  /**
    +    * Return a padding result with the given left/right row.
    +    * @param row the row to pad
    +    * @param paddingLeft pad left or right
    +    * @return the null padding result
    +    */
    +  private def paddingResult(row: Row, paddingLeft: Boolean): Row = {
    --- End diff --
    
    Move this method into a util class and split it into two method (`padLeft` and `padRight`).
The methods should be `final`.


> Add support for windowed outer joins for streaming tables
> ---------------------------------------------------------
>
>                 Key: FLINK-7797
>                 URL: https://issues.apache.org/jira/browse/FLINK-7797
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>    Affects Versions: 1.4.0
>            Reporter: Fabian Hueske
>            Assignee: Xingcan Cui
>
> Currently, only windowed inner joins for streaming tables are supported.
> This issue is about adding support for windowed LEFT, RIGHT, and FULL OUTER joins.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message