flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7797) Add support for windowed outer joins for streaming tables
Date Sat, 09 Dec 2017 02:30:03 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284543#comment-16284543
] 

ASF GitHub Bot commented on FLINK-7797:
---------------------------------------

GitHub user xccui opened a pull request:

    https://github.com/apache/flink/pull/5140

    [FLINK-7797] [table] Add support for windowed outer joins for streaming tables

    ## What is the purpose of the change
    
    This PR adds support for windowed outer joins for streaming tables.
    
    ## Brief change log
    
      - Adjusts the plan translation logic to accept stream window outer join.
      - Adheres an ever emitted flag to each row. When a row is removed from the cache (or
detected as not cached), a null padding join result will be emitted if necessary.
      - Adds a custom `JoinAwareCollector` to track whether there's a successfully joined
result for both sides in each join loop.
      - Adds table/SQL translation tests, and also join integration tests. Since the runtime
logic is built on the existing window inner join, no new harness tests are added.
     - Updates the SQL/Table API docs.
    
    ## Verifying this change
    
    This PR can be verified by the cases added in `JoinTest` and `JoinITCase`.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (**yes**)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (**yes**)
      - If yes, how is the feature documented? (**removes the restriction notes**)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xccui/flink FLINK-7797

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5140.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5140
    
----
commit 34d3fde8049ec407849b61901acd8258a6a1f919
Author: Xingcan Cui <xingcanc@gmail.com>
Date:   2017-12-07T17:28:40Z

    [FLINK-7797] [table] Add support for windowed outer joins for streaming tables

----


> Add support for windowed outer joins for streaming tables
> ---------------------------------------------------------
>
>                 Key: FLINK-7797
>                 URL: https://issues.apache.org/jira/browse/FLINK-7797
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>    Affects Versions: 1.4.0
>            Reporter: Fabian Hueske
>            Assignee: Xingcan Cui
>
> Currently, only windowed inner joins for streaming tables are supported.
> This issue is about adding support for windowed LEFT, RIGHT, and FULL OUTER joins.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message