flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7468) Implement sender backlog logic for credit-based
Date Thu, 07 Dec 2017 08:41:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281502#comment-16281502
] 

ASF GitHub Bot commented on FLINK-7468:
---------------------------------------

Github user zhijiangW commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4559#discussion_r155458048
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionView.java
---
    @@ -145,6 +145,10 @@ public Buffer getNextBuffer() throws IOException, InterruptedException
{
     					listener.notifyBuffersAvailable(1);
     				}
     
    +				if (current.isBuffer()) {
    --- End diff --
    
    I think the `decreaseStatistics` should be inside the `getNextBufferInternal`, otherwise
the backlog value is not thread-safe. The previous implementation can make the 'decreaseStatistics`
inside the synchronized part.


> Implement sender backlog logic for credit-based
> -----------------------------------------------
>
>                 Key: FLINK-7468
>                 URL: https://issues.apache.org/jira/browse/FLINK-7468
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Network
>            Reporter: zhijiang
>            Assignee: zhijiang
>             Fix For: 1.5.0
>
>
> This is a part of work for credit-based network flow control.
> Receivers should know how many buffers are available on the sender side (the backlog).
The receivers use this information to decide how to distribute floating buffers.
> The {{ResultSubpartition}} maintains the backlog which only indicates the number of buffers
in this subpartition, not including the number of events. The backlog is increased for adding
buffer to this subpartition, and decreased for polling buffer from it.
> The backlog is attached in {{BufferResponse}} by sender as an absolute value after the
buffer being transferred.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message