flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #5140: [FLINK-7797] [table] Add support for windowed oute...
Date Fri, 29 Dec 2017 00:28:47 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5140#discussion_r159014190
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamJoin.scala
---
    @@ -133,6 +149,19 @@ abstract class TimeBoundedStreamInnerJoin(
         val rightTimerStateDesc: ValueStateDescriptor[Long] =
           new ValueStateDescriptor[Long]("InnerJoinRightTimerState", classOf[Long])
         rightTimerState = getRuntimeContext.getState(rightTimerStateDesc)
    +
    +
    +    // Initialize the two reusable padding results.
    +    var i = 0
    +    while (i < leftArity) {
    --- End diff --
    
    Move to util class


---

Mime
View raw message