flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dawidwys <...@git.apache.org>
Subject [GitHub] flink pull request #5141: [FLINK-8226] [cep] Dangling reference generated af...
Date Wed, 27 Dec 2017 13:19:17 GMT
Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5141#discussion_r158811709
  
    --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/SharedBuffer.java
---
    @@ -82,9 +82,12 @@
     
     	private transient Map<K, SharedBufferPage<K, V>> pages;
     
    +	private final transient List<SharedBufferEntry<K, V>> prunedEntries;
    --- End diff --
    
    Is it necessary for it to be a field? Isn't a local variable sufficient?


---

Mime
View raw message