flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shuai-xu <...@git.apache.org>
Subject [GitHub] flink pull request #5190: [FLINK-8289] [runtime] set the rest.address to the...
Date Mon, 25 Dec 2017 07:40:28 GMT
Github user shuai-xu commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5190#discussion_r158627004
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/ClusterEntrypoint.java
---
    @@ -155,6 +156,7 @@ protected void runCluster(Configuration configuration) throws Exception
{
     			// write host information into configuration
     			configuration.setString(JobManagerOptions.ADDRESS, commonRpcService.getAddress());
     			configuration.setInteger(JobManagerOptions.PORT, commonRpcService.getPort());
    +			configuration.setString(RestOptions.REST_ADDRESS, commonRpcService.getAddress());
    --- End diff --
    
    I think what we want to get from the RestServerEndpoint is its server address. One way
is to let its bind address to be the real ip of the machine. The common rpc address now is
the real ip. 


---

Mime
View raw message