flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #5168: [FLINK-8234][flip6] WIP
Date Mon, 18 Dec 2017 13:36:21 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5168#discussion_r157481165
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
---
    @@ -357,6 +362,28 @@ public void start() throws Exception {
     		return CompletableFuture.completedFuture(jobManagerServices.blobServer.getPort());
     	}
     
    +	@Override
    +	public CompletableFuture<Either<Throwable, SerializedJobExecutionResult>>
getJobExecutionResult(
    --- End diff --
    
    I fear we cannot directly use a `Throwable` here, because it might be a user defined throwable.
Therefore, we have to use `SerializedThrowable` instead.


---

Mime
View raw message