flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #5168: [FLINK-8234][flip6] WIP
Date Mon, 18 Dec 2017 13:36:21 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5168#discussion_r157480619
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/JobExecutionResultResponseBody.java
---
    @@ -0,0 +1,69 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.rest.messages.job;
    +
    +import org.apache.flink.runtime.rest.messages.ResponseBody;
    +import org.apache.flink.runtime.rest.messages.queue.QueueStatus;
    +
    +import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonCreator;
    +import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonProperty;
    +
    +import javax.annotation.Nullable;
    +
    +import static java.util.Objects.requireNonNull;
    +
    +/**
    + * {@link ResponseBody} that carries a {@link QueueStatus} and a {@link JobExecutionResult}.
    + *
    + * @see org.apache.flink.runtime.rest.handler.job.JobExecutionResultHandler
    + */
    +public class JobExecutionResultResponseBody implements ResponseBody {
    +
    +	@JsonProperty(value = "status", required = true)
    +	private final QueueStatus status;
    --- End diff --
    
    Could this be an `enum`? Then we wouldn't create JSON like 
    ```
    "status": {
     "id": "..."
    }
    ```


---

Mime
View raw message