flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dawidwys <...@git.apache.org>
Subject [GitHub] flink issue #5142: [FLINK-8227] Optimize the performance of SharedBufferSeri...
Date Sun, 17 Dec 2017 14:35:49 GMT
Github user dawidwys commented on the issue:

    https://github.com/apache/flink/pull/5142
  
    I think it is a very good and needed change.
    
    As for @StephanEwen questions:
    
    Ad 1. I see no problem with this `entryId` being primitive `int`. 
    Ad 2. I think this field should be transient it is used only during the serialization
process to reflect the order in which we serialize the SharedBufferEntries to restore the
links between them. It does not play any role outside of serialization.
    Ad 3. I agree it should be at least long. It will limit  the number of intermittent state
of pattern graph.
    
    After changing `int` to `long` I think it is ok to be merged.


---

Mime
View raw message