flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pnowojski <...@git.apache.org>
Subject [GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...
Date Fri, 15 Dec 2017 13:15:20 GMT
Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5105#discussion_r156931262
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordOrEventCollectingResultPartitionWriter.java
---
    @@ -0,0 +1,104 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.io.network.api.writer;
    +
    +import org.apache.flink.api.common.typeutils.TypeSerializer;
    +import org.apache.flink.runtime.event.AbstractEvent;
    +import org.apache.flink.runtime.io.network.api.serialization.AdaptiveSpanningRecordDeserializer;
    +import org.apache.flink.runtime.io.network.api.serialization.EventSerializer;
    +import org.apache.flink.runtime.io.network.api.serialization.RecordDeserializer;
    +import org.apache.flink.runtime.io.network.buffer.Buffer;
    +import org.apache.flink.runtime.io.network.buffer.BufferProvider;
    +import org.apache.flink.runtime.io.network.partition.ResultPartitionID;
    +import org.apache.flink.runtime.plugable.DeserializationDelegate;
    +import org.apache.flink.runtime.plugable.NonReusingDeserializationDelegate;
    +
    +import java.io.IOException;
    +import java.util.Collection;
    +
    +import static org.apache.flink.util.Preconditions.checkNotNull;
    +import static org.apache.flink.util.Preconditions.checkState;
    +
    +/**
    + * {@link ResultPartitionWriter} that collects records or events on the List.
    --- End diff --
    
    it's a specific user supplied list (`the` vs `a`), and "on" seems to me better as well:
    http://learnersdictionary.com/qa/is-it-correct-to-say-on-the-list-or-in-the-list
    https://www.englishforums.com/English/OnTheListOrInTheList/wzblc/post.htm
    



---

Mime
View raw message