flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #5087: [FLINK-8085] Thin out LogicalSlot interface
Date Wed, 13 Dec 2017 17:26:48 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5087#discussion_r156727267
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
---
    @@ -331,8 +334,19 @@ public void setInitialState(TaskStateSnapshot checkpointStateHandles)
{
     	 *
     	 * @return A future for the execution's termination
     	 */
    -	public CompletableFuture<ExecutionState> getTerminationFuture() {
    -		return terminationFuture;
    +	@Override
    +	public CompletableFuture<ExecutionState> getTerminalStateFuture() {
    +		return terminalStateFuture;
    +	}
    +
    +	/**
    +	 * Gets the release future which is completed once the execution reaches a terminal
    +	 * state and the assigned resource has been released.
    +	 *
    +	 * @return
    --- End diff --
    
    Will add a description


---

Mime
View raw message