flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink issue #4911: [FLINK-7878] [api] make resource type extendible in Resou...
Date Wed, 13 Dec 2017 16:37:51 GMT
Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/4911
  
    Changes look good @shuai-xu. I have a single last question which is whether we want to
expose the `GpuResource` to the user or not. Wouldn't it be enough to set the gpus via `Builder#setGpuResource(double)`?
Of course, then we weren't able to set the `ResourceAggregateType` but I'm wondering whether
GPUs shouldn't be something else than the sum. We actually have the same problem with the
cpus. They are hardcoded to be the max of both values.


---

Mime
View raw message