flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aljoscha <...@git.apache.org>
Subject [GitHub] flink pull request #5154: [FLINK-8213][metrics] Guard against metric-related...
Date Tue, 12 Dec 2017 14:09:46 GMT
Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5154#discussion_r156371977
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
---
    @@ -264,8 +264,8 @@ public JobMaster(
     			this.jobManagerMetricGroup = jobManagerMetricGroup;
     			this.jobMetricGroup = jobManagerMetricGroup.addJob(jobGraph);
     		} else {
    -			this.jobManagerMetricGroup = new UnregisteredMetricsGroup();
    -			this.jobMetricGroup = new UnregisteredMetricsGroup();
    +			this.jobManagerMetricGroup = UnregisteredMetricGroups.JOB_MANAGER;
    --- End diff --
    
    I think those static fields are not available anymore so this commit alone would not compile


---

Mime
View raw message