flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #5064: [FLINK-8145][tests] fix various IOManagerAsync ins...
Date Tue, 12 Dec 2017 10:26:48 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5064#discussion_r156324988
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/HashTablePerformanceComparison.java
---
    @@ -54,7 +55,12 @@
     	
     	private final TypePairComparator<IntPair, IntPair> pairComparator = new IntPairPairComparator();
     	
    -	private IOManager ioManager = new IOManagerAsync();
    +	private static final IOManager ioManager = new IOManagerAsync();
    --- End diff --
    
    this one is only used in a single test, don't think we need it as a field


---

Mime
View raw message