flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ankitiitb1069 <...@git.apache.org>
Subject [GitHub] flink pull request #5121: [FLINK-8116] Stale comments referring to Checkpoin...
Date Fri, 08 Dec 2017 21:18:28 GMT
Github user ankitiitb1069 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5121#discussion_r155877893
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/SourceFunction.java
---
    @@ -34,17 +34,17 @@
      * The run method can run for as long as necessary. The source must, however, react to
an
      * invocation of {@link #cancel()} by breaking out of its main loop.
      *
    - * <h3>Checkpointed Sources</h3>
    + * <h3>CheckpointedFunction Sources</h3>
      *
    - * <p>Sources that also implement the {@link org.apache.flink.streaming.api.checkpoint.Checkpointed}
    + * <p>Sources that also implement the {@link org.apache.flink.streaming.api.checkpoint.CheckpointedFunction}
      * interface must ensure that state checkpointing, updating of internal state and emission
of
      * elements are not done concurrently. This is achieved by using the provided checkpointing
lock
      * object to protect update of state and emission of elements in a synchronized block.
      *
      * <p>This is the basic pattern one should follow when implementing a (checkpointed)
source:
      *
      * <pre>{@code
    - *  public class ExampleSource<T> implements SourceFunction<T>, Checkpointed<Long>
{
    + *  public class ExampleSource<T> implements SourceFunction<T>, CheckpointedFunction<Long>
{
    --- End diff --
    
    Please check, I have made the changes, but could not make up what to write inside of these
functions


---

Mime
View raw message