flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #5068: [FLINK-8122] [table] Name all built-in table sinks...
Date Thu, 07 Dec 2017 11:21:28 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5068#discussion_r155489738
  
    --- Diff: flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSinkTestBase.java
---
    @@ -54,6 +57,7 @@
     	@Test
     	public void testKafkaTableSink() throws Exception {
     		DataStream dataStream = mock(DataStream.class);
    +		when(dataStream.addSink(any(SinkFunction.class))).thenReturn(mock(DataStreamSink.class));
    --- End diff --
    
    Why do we need this change? Does it fix the test?
    It does not add an assertion to the test.


---

Mime
View raw message