flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #5068: [FLINK-8122] [table] Name all built-in table sinks...
Date Thu, 07 Dec 2017 11:21:28 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5068#discussion_r155493746
  
    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/table/TableSourceITCase.scala
---
    @@ -58,7 +58,7 @@ class TableSourceITCase(
           override def getDataSet(execEnv: JExecEnv): DataSet[Row] = {
             val data = List(Row.of("Mary", new JLong(1L), new JInt(1))).asJava
             // return DataSet[Row] with GenericTypeInfo
    -        execEnv.fromCollection(data, new GenericTypeInfo[Row](classOf[Row]))
    +        execEnv.fromCollection(data, new GenericTypeInfo[Row](classOf[Row])).name(explainSource())
    --- End diff --
    
    I don't think we have to add this to test sources.


---

Mime
View raw message