flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink issue #5065: [FLINK-8139][table] Check for proper equals() and hashCod...
Date Thu, 07 Dec 2017 10:16:40 GMT
Github user fhueske commented on the issue:

    Hmm, I agree with @twalthr. Adding these checks when a DataSet/DataStream is imported
would prevent valid queries (e.g., those that to simple transformations). I would not add
a config switch to disable the global checks. Adding the checks to the operators that require
properly implemented `equals()` and `hashCode()` methods sounds like a better approach. 
    We should also add to the documentation that all objects that are processed by the Table
API / SQL should have equals and hashCode properly implemented.


View raw message